Welcome to the LimeSurvey Community Forum

Ask the community, share ideas, and connect with other LimeSurvey users!

Blocking(!) fault in the community 7.0.15 download packaging

More
2 hours 34 minutes ago #275156 by Selcal
Unfortunately the bug tracker does not allow me to post a bug (unknown value for 'version' error).
So posting here:


download.limesurvey.org/latest-master/li...vey7.0.15+260910.zip does not contain a complete functional build of editor

Comparing the 7.0.14 and 7.0.15 packages, diff -rq on editor/build/
reports no differing files. 7.0.15 contains every file 7.0.14 does, byte
identical, plus five extra files and nothing else:

  build/static/css/index.12b7cb60.css
  build/static/js/index.16e5953f.js
  build/static/js/index.84184aad.js
  build/static/js/index.9ceeb445.js
  build/static/js/index.c0bdff1d.js

The commit hashes baked in by build.cjs (REACT_APP_COMMIT_HASH, visible
in the React Query cache-buster) show 7.0.14 built from one commit:

  7.0.14   index.92adc8c9.js   17dce31b...

and 7.0.15 carrying four:

  index.92adc8c9.js   17dce31b...   (same build as 7.0.14)
  index.84184aad.js   15432b98...
  index.16e5953f.js   fde21144...
  index.9ceeb445.js   fde21144...
  index.c0bdff1d.js   e8305a43...

7.0.14's editor/index.html references index.92adc8c9.js. 7.0.15's
references index.84184aad.js, from the older 15432b98 build, together
with lib-axios.d29b975f.js, 164.337bcd42.js and 164.4d7519f5.css, none
of which are in the package. The question editor 404s and renders blank.

More seriously, editor/src/ gained six files in 7.0.15, including
src/hooks/useEditorCompatibilityGuard.js and
src/components/QuestionSettings/DefaultValuesActions.js. Neither string
appears in any bundle under editor/build/static/js/. The editor source
advanced for 7.0.15 but the build was never regenerated, so 7.0.15's
editor is 7.0.14's editor even once index.html is corrected.

rsbuild.config.js sets html.template './public/index.html' and
output.distPath.root 'build', so the generated entry belongs at
build/index.html; there is none in either package. build.cjs runs
'bash postbuild.sh' if present, and postbuild.sh is not shipped - likely
the step that relocates it to editor/index.html.

To reproduce:
Download the file, after install, run any editor page. The page is empty (404s on the .js files)

Or, no installation:
1. cd limesurvey/editor
2. grep -oE '(src|href)="[^"]*"' index.html | sed 's/.*="//;s/"$//'
3. Check each path against the extracted tree, e.g.
     ls build/static/js/ build/static/css/

#### Expected result

Every asset referenced by editor/index.html exists in the package and
belongs to the same build.

#### Actual result

build/static/js/lib-router.ff97bacb.js   - missing
build/static/js/lib-axios.d29b975f.js    - missing
build/static/js/164.337bcd42.js          - missing
build/static/css/164.4d7519f5.css        - missing

build/static/js/ instead contains lib-router.19011544.js,
lib-axios.83949709.js and 859.5acbe722.js, plus five index.*.js files.

Repeating the same check on the 7.0.14 package shows no missing
references.

Please Log in to join the conversation.

Moderators: holchtpartner

Lime-years ahead

Online-surveys for every purse and purpose