Hi folx,

you silently changed the head.twig file from release 3.9.0+180604 to 3.10.0+180611 in the vanilla theme:

to

I'm not familiar with pjax but this change - or the consequence of it, made that if the event would remain in the theme, the functionality broke in the following way:

In 3.9.0+180604 the clearall-process openes a browser alert (or something close to) confirmation dialog. In the latest version it opens a bootstrap modal. If remains in the theme because it has been changed due to theme-customization (no chance for inheritance anymore) the modal gets loaded twice. This causes that it doesn't react on click events anymore. The only way out is to reload the page.

This situation could potentially happen with every single LS update so my question is how can I face this problem. The customer I'm doing it for is huge. If this happens during a running survey - :evil:

Shall I set up a theme from the scratch instead?

Don't get me wrong: As a user I really like the theme editor and inheritance/ extension architecture.

If you experience the problem with the latest version, please file a bug report.

markus, who wrote this part of the code, is not here today. I'll ask him to answer you as soon as he's back

Please ignore this. It was a reply to the previous answer.

I agree, this should not happen.

But:

If this happens during a running survey - :evil:

Then you are doing it wrong.

Don't update during a running survey, if you can avoid it. I know, things like this should not happen, but they do. Thus, we as the user need to protect ourselves from these things by keeping the risk as low as possible when important surveys are running.

If the client is so important, then you should always run a test environment, where you do the update/upgrade first and test it thoroughly. Only once the tests were successful, then you update the production system. This way you should have caught the problem before it went live.

The issue with inheritance is you never can't know if user file was updated. If we update a twig file and you update same twig file : we can not know if your update was compatible.

Mybb ( mybb.com/ ) have a diff system


You can make a Feature request for same system (and better : a pull request or a plugin), but still : you need to track down the difference and fix it yourself.