I noticed when i was investigating an issue with kcfinder ( bugs.limesurvey.org/view.php?id=13982 ) that the entire /third_party directory is marked as "binary" in /third_party/.gitattributes:

* binary

See commit: github.com/LimeSurvey/LimeSurvey/commit/...31d83b3663a79fd18e5e

Marking the entire tree as binary makes using 'git diff' unusable because git just says that the binary files have changed vs. showing the actual difference. So does anyone know why the entire tree should be marked as binary?

Yes : totally right !

Objective was to "just" third_party to "official" release, and use extended class for LimeSurvey. But since we use own system : there are 2 solution
1. Fork each third_party (and framework, since there are own fix/update inisde) in github.com/LimeSurvey . And use this fork in third_party
2. Disable bin in this 2 directories.

Denis, is there an answer to the question "why the entire tree should be marked as binary?".

Are the solutions, you propose towards LimeSurvey developers, which control the GITHUB LimeSurvey repository? Or for caseylucas?

Thanks.

jelo wrote: Denis, is there an answer to the question "why the entire tree should be marked as binary?".

me wrote: Objective was to "just" third_party to "official" release, and use extended class for LimeSurvey.

My english is sooooooo baaaaad

I think (unsure) : framework and third party must be "exactly the same than original", and can be added using composer etc … then no need to track down change : can be binary.

jelo wrote: Are the solutions, you propose towards LimeSurvey developers, which control the GITHUB LimeSurvey repository? Or for caseylucas?

For LimeSurvey GMBH team , but maybe more Menno here ?

github.com/LimeSurvey/LimeSurvey/commit/...31d83b3663a79fd18e5e

Merge request done github.com/LimeSurvey/LimeSurvey/pull/1136
Introduced here : github.com/LimeSurvey/LimeSurvey/commit/...0b6fe5421d603731ba71

Nice. I could have done PR but wasn't sure of any other implications. Thanks.

Iwasn't sure too (and if no answer during one week : i can merge it )

Binary was introduced because of line feed issues. Some libraries come with different linefeed settings than the one we have set in Git for developing. So if you update the library it is changed and then you have to fix the line feeds which is a regular change for Git.
So we introduced the Binary command so that the libraries are not touched anymore and can be committed as-is.
So just removing the command is not a solution as it will bring up the previous issue, again.

OK,

When repo are on gitb : we can copy each gitattribute. github.com/yiisoft/yii/blob/master/.gitattributes

For other : did you remind a third_party with crlf linefeed ?

I close the pull request,

What must be done
1. remove current .gitattribute
2. Test all third party : git checkout-index --force --all
3. See if current version have a gitattribute on one of directory (framework have one)
4. Go back to 1 with this one
5. Add and update a .gitattribute in each directory
6. Do 2 again
7. Go back to 1