Welcome to the LimeSurvey Community Forum

Ask the community, share ideas, and connect with other LimeSurvey users!

LimeSurvey 3.0.0 Release Candidate 3 released

More
6 years 4 months ago #160806 by fvanderstarre
Replied by fvanderstarre on topic LimeSurvey 3.0.0 Release Candidate 3 released
That's what I did - edited my copy of Vanilla and saved the template.css file. See attachment.

File Attachment:

File Name: AMC_vanilla.zip
File Size:147 KB
Attachments:
The topic has been locked.
  • LouisGac
  • LouisGac's Avatar
  • Visitor
  • Visitor
6 years 4 months ago #160808 by LouisGac
Replied by LouisGac on topic LimeSurvey 3.0.0 Release Candidate 3 released
ok I confirm the bug.
Thank you, that's exactly the kind of bug reports we're waiting for now.
The topic has been locked.
More
6 years 4 months ago #160809 by fvanderstarre
Replied by fvanderstarre on topic LimeSurvey 3.0.0 Release Candidate 3 released
You're welcome. Do you want me to report it in the bug tracker?
The topic has been locked.
  • LouisGac
  • LouisGac's Avatar
  • Visitor
  • Visitor
6 years 4 months ago #160810 by LouisGac
Replied by LouisGac on topic LimeSurvey 3.0.0 Release Candidate 3 released
yes you can. I'm already working on it.
We should have tested it before releasing the RC.
It's a problem with template.css not being loaded at all.
You can still do your tests with the default template.
The topic has been locked.
  • LouisGac
  • LouisGac's Avatar
  • Visitor
  • Visitor
6 years 4 months ago #160811 by LouisGac
Replied by LouisGac on topic LimeSurvey 3.0.0 Release Candidate 3 released
Ok, I just pushed the fix:
github.com/LimeSurvey/LimeSurvey/commit/...f520ef3261115885907c

Problem was that when using a single file in the manifest (like only template.css and no other css file), then it was converted to string instead of array in db...
github.com/LimeSurvey/LimeSurvey/blob/de...t/config.xml#L29-L33
VS:
github.com/LimeSurvey/LimeSurvey/blob/de...a/config.xml#L29-L31

So an easy way for you to fix it without applying the patch is just to add a dummy (even non existing) css file to the manifest, and then uninstall and reinstall.
The topic has been locked.
More
6 years 4 months ago #160978 by fvanderstarre
Replied by fvanderstarre on topic LimeSurvey 3.0.0 Release Candidate 3 released
How do I "... add a dummy (even non existing) css file to the manifest, ..." ? It's not that obvious to me I'm afraid.
The topic has been locked.
  • LouisGac
  • LouisGac's Avatar
  • Visitor
  • Visitor
6 years 4 months ago - 6 years 4 months ago #160979 by LouisGac
Replied by LouisGac on topic LimeSurvey 3.0.0 Release Candidate 3 released
links are dead...

github.com/LimeSurvey/LimeSurvey/blob/de...a/config.xml#L24-L38

So in your custom template, instead of:
Code:
 
    <files>
        <css>
            <add>css/theme.css</add>
        </css>
        <js>
            <add>scripts/theme.js</add>
        </js>
        <print_css>
            <add>css/print_theme.css</add>
        </print_css>
    </files>
 

add:
Code:
 
    <files>
        <css>
            <add>css/theme.css</add>
            <add>css/dummy.css</add>
        </css>
        <js>
            <add>scripts/theme.js</add>
            <add>scripts/dummy.js</add>
        </js>
        <print_css>
            <add>css/print_theme.css</add>
        </print_css>
    </files>
 

because the files dummy.css/js don't exist, they will not be added to the package, but it will fix the generated json from the XML
Last edit: 6 years 4 months ago by LouisGac.
The topic has been locked.
More
6 years 4 months ago #161075 by fvanderstarre
Replied by fvanderstarre on topic LimeSurvey 3.0.0 Release Candidate 3 released
I applied the changes you suggested, deinstalled and installed the custom template, but this still didn't have any effect on question or EM tip display...
The topic has been locked.
  • LouisGac
  • LouisGac's Avatar
  • Visitor
  • Visitor
6 years 4 months ago #161081 by LouisGac
Replied by LouisGac on topic LimeSurvey 3.0.0 Release Candidate 3 released
I should release today or tomorrow a RC4, so don't worry.
The topic has been locked.
  • holch
  • holch's Avatar
  • Offline
  • LimeSurvey Community Team
  • LimeSurvey Community Team
More
6 years 3 months ago #161999 by holch
Replied by holch on topic LimeSurvey 3.0.0 Release Candidate 3 released

LouisGac wrote: I should release today or tomorrow a RC4, so don't worry.


I assume it is save to say that there won't be a RC4 nor a stable LS 3.0.0 this year, right?
I answer at the LimeSurvey forum in my spare time, I'm not a LimeSurvey GmbH employee.
No support via private message.
The topic has been locked.
  • LouisGac
  • LouisGac's Avatar
  • Visitor
  • Visitor
6 years 3 months ago #162003 by LouisGac
Replied by LouisGac on topic LimeSurvey 3.0.0 Release Candidate 3 released
well if today is this year, then we'll have a LS3 Master released this this year.
The topic has been locked.
  • holch
  • holch's Avatar
  • Offline
  • LimeSurvey Community Team
  • LimeSurvey Community Team
More
6 years 3 months ago #162004 by holch
Replied by holch on topic LimeSurvey 3.0.0 Release Candidate 3 released
I would count today still as this year. ;-)

So taking this response, this means there will be no RC4 but we'll go straight to LS 3.0.0 stable and it will be available today?

Sounds exiting!
I answer at the LimeSurvey forum in my spare time, I'm not a LimeSurvey GmbH employee.
No support via private message.
The topic has been locked.

Lime-years ahead

Online-surveys for every purse and purpose

Pricing & Plans
Get started

Legal

About Us

Open Source